linux-kernel - re: thermal: qcom: tsens-v1: Add support for MSM8956 and MSM8976

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <f7f9386f-b87a-a3e3-dbf2-09c69c1a5669@canonical.com>
Date:   Tue, 22 Oct 2019 12:57:09 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     AngeloGioacchino Del Regno <kholk11@...il.com>,
        Amit Kucheria <amit.kucheria@...aro.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Andy Gross <agross@...nel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: re: thermal: qcom: tsens-v1: Add support for MSM8956 and MSM8976

Hi,

Static analysis on linux-next has found a potential issue in commit:

commit 95ededc17e4e55a5fbb106f63cea06defc963a37
Author: AngeloGioacchino Del Regno <kholk11@...il.com>
Date:   Sat Oct 5 12:41:31 2019 +0200

    thermal: qcom: tsens-v1: Add support for MSM8956 and MSM8976

Namely in drivers/thermal/qcom/tsens-v1.c, function calibrate_8976().
The analysis is as follows:

        switch (mode) {
        case TWO_PT_CALIB:

CID 90463 (#1 of 1): Operands don't affect result
(CONSTANT_EXPRESSION_RESULT)
result_independent_of_operands: (qfprom_cdata[2] & 255) >> 8 is 0
regardless of the values of its operands. This occurs as the operand of
assignment.

                base1 = (qfprom_cdata[2] & MSM8976_BASE1_MASK) >>
MSM8976_BASE1_SHIFT;

This seems to indicate that the shift and/or mask is not correct as the
result will always be zero.

Colin