linux-kernel - Re: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191023232004.GV3125@piout.net>
Date:   Thu, 24 Oct 2019 01:20:04 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     "Luck, Tony" <tony.luck@...el.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        Stephane Eranian <eranian@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver

On 23/10/2019 21:30:29+0000, Luck, Tony wrote:
> >> rtc-efi rtc-efi: setting system clock to 2019-10-23T18:30:23 UTC (1571855423)
> 
> > You can remove CONFIG_RTC_HCTOSYS, this line will disappear, systemd
> > will not like that but efirtc was not setting the system time anyway so
> > this shouldn't change the behaviour.
> 
> 
> Wait ... that message says "setting system clock"
> 
> but then you say " efirtc was not setting the system time anyway".
> 
> So did the time get set, or not?
> 
> If it wasn't set, why does the message say that it was set?
> 

What I meant was that drivers/char/efirtc.c was not setting the system
time but when using drivers/rtc/rtc-efi.c with CONFIG_RTC_HCTOSYS, the
kernel will use the rtc to set the system time.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com