linux-kernel - Re: New sysfs interface for privacy screens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191023083928.GR11828@phenom.ffwll.local>
Date:   Wed, 23 Oct 2019 10:39:28 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Jani Nikula <jani.nikula@...ux.intel.com>
Cc:     Mat King <mathewk@...gle.com>, Sean Paul <seanpaul@...omium.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>, rafael@...nel.org,
        Greg KH <gregkh@...uxfoundation.org>,
        Ross Zwisler <zwisler@...gle.com>,
        Jingoo Han <jingoohan1@...il.com>,
        Rajat Jain <rajatja@...gle.com>,
        Lee Jones <lee.jones@...aro.org>,
        Ville Syrjälä 
        <ville.syrjala@...ux.intel.com>, David Airlie <airlied@...hat.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Alexander Schremmer <alex@...xanderweb.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: New sysfs interface for privacy screens

On Tue, Oct 08, 2019 at 09:13:51AM +0300, Jani Nikula wrote:
> On Mon, 07 Oct 2019, Mat King <mathewk@...gle.com> wrote:
> > That makes sense; just to confirm can a property be added or removed
> > after the connector is registered?
> 
> You need to create the property before registering the drm device. You
> can attach/detach the property later, but I should think you know by the
> time you're registering the connector whether it supports the privacy
> screen or not.

I don't think you can add/remove a property after the object you're
adding/removing the prop from has gone public (either with
drm_dev_register or drm_connector_register for hotplugged connectors).

I guess another gap we should cover with some WARN_ON?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch