linux-kernel - Re: [PATCH v2 1/2] habanalabs: support kernel memory mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191023092035.GA12222@infradead.org>
Date:   Wed, 23 Oct 2019 02:20:35 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Omer Shpigelman <oshpigelman@...ana.ai>
Cc:     "oded.gabbay@...il.com" <oded.gabbay@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] habanalabs: support kernel memory mapping

On Tue, Oct 22, 2019 at 06:30:35AM +0000, Omer Shpigelman wrote:
> Changes in v2:
>  - use a boolean parameter to indicate for kernel address rather than
>    calling is_vmalloc_addr, as kernel and user addresses can overlap on
>    some architectures.

That is still broken.  Please use an actual kernel pointer instead of
losing all type safety by casting it an integer type.