linux-kernel - RE: [PATCH v2 1/2] habanalabs: support kernel memory mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR0202MB3382B554A4C7F0F677A804D7B86B0@AM6PR0202MB3382.eurprd02.prod.outlook.com>
Date:   Wed, 23 Oct 2019 13:39:41 +0000
From:   Omer Shpigelman <oshpigelman@...ana.ai>
To:     Christoph Hellwig <hch@...radead.org>
CC:     "oded.gabbay@...il.com" <oded.gabbay@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/2] habanalabs: support kernel memory mapping

On Thu, Oct 23, 2019 at 12:21 PM Christoph Hellwig <hch@...radead.org> wrote:
> On Tue, Oct 22, 2019 at 06:30:35AM +0000, Omer Shpigelman wrote:
> > Changes in v2:
> >  - use a boolean parameter to indicate for kernel address rather than
> >    calling is_vmalloc_addr, as kernel and user addresses can overlap on
> >    some architectures.
> 
> That is still broken.  Please use an actual kernel pointer instead of losing all
> type safety by casting it an integer type.

I'm not sure I understand. Can you please pin point the problematic line?