linux-kernel - Re: [PATCH] rtl8xxxu: remove set but not used variable 'rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Oct 2019 18:10:50 +0800
From:   Chris Chiu <chiu@...lessm.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Jes Sorensen <Jes.Sorensen@...il.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        David Miller <davem@...emloft.net>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask'

On Wed, Oct 23, 2019 at 3:54 PM YueHaibing <yuehaibing@...wei.com> wrote:
>
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6:
>  warning: variable rate_mask set but not used [-Wunused-but-set-variable]
>
> It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve
> TX performance of RTL8723BU on rtl8xxxu driver")
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
Singed-off-by: Chris Chiu <chiu@...lessm.com>

>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index 1e3b716..3843d7a 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -4481,11 +4481,6 @@ static u16
>  rtl8xxxu_wireless_mode(struct ieee80211_hw *hw, struct ieee80211_sta *sta)
>  {
>         u16 network_type = WIRELESS_MODE_UNKNOWN;
> -       u32 rate_mask;
> -
> -       rate_mask = (sta->supp_rates[0] & 0xfff) |
> -                   (sta->ht_cap.mcs.rx_mask[0] << 12) |
> -                   (sta->ht_cap.mcs.rx_mask[0] << 20);
>
>         if (hw->conf.chandef.chan->band == NL80211_BAND_5GHZ) {
>                 if (sta->vht_cap.vht_supported)
> --
> 2.7.4

Thanks for pointing that out.

Chris