linux-kernel - Re: [PATCH] rtl8xxxu: remove set but not used variable 'rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sgnjeph0.fsf@tynnyri.adurom.net>
Date:   Wed, 23 Oct 2019 13:16:43 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Chris Chiu <chiu@...lessm.com>
Cc:     YueHaibing <yuehaibing@...wei.com>,
        Jes Sorensen <Jes.Sorensen@...il.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        David Miller <davem@...emloft.net>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask'

Chris Chiu <chiu@...lessm.com> writes:

> On Wed, Oct 23, 2019 at 3:54 PM YueHaibing <yuehaibing@...wei.com> wrote:
>>
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6:
>>  warning: variable rate_mask set but not used [-Wunused-but-set-variable]
>>
>> It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve
>> TX performance of RTL8723BU on rtl8xxxu driver")
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
> Singed-off-by: Chris Chiu <chiu@...lessm.com>

In the future please use Reviewed-by:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

Signed-off-by is supposed to be used when you are sending a patch and
Acked-by is used by the driver maintainer, in this case Jes.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches