linux-kernel - RE: [PATCH v2 1/2] habanalabs: support kernel memory mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR0202MB3382CAB4D348F568EFBAC237B86A0@AM6PR0202MB3382.eurprd02.prod.outlook.com>
Date:   Thu, 24 Oct 2019 08:07:01 +0000
From:   Omer Shpigelman <oshpigelman@...ana.ai>
To:     Christoph Hellwig <hch@...radead.org>
CC:     "oded.gabbay@...il.com" <oded.gabbay@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/2] habanalabs: support kernel memory mapping

On Thu, Oct 24, 2019 at 04:29 AM Christoph Hellwig <hch@...radead.org> wrote:
> On Wed, Oct 23, 2019 at 01:39:41PM +0000, Omer Shpigelman wrote:
> > I'm not sure I understand. Can you please pin point the problematic line?
> 
> Every line you touch addr field basically.  If you have a kernel address please
> store it in an actual C pointer type, not in a u64 to ensure that the compiler
> can do proper type checking.

I see your point. I'll separate the code so the kernel address path will use a pointer type rather than u64.