linux-kernel - Re: [PATCH v2 08/22] mtd: spi-nor: Rework write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e11ac30-98fa-98c5-3f2e-3fb1f373ffe1@microchip.com>
Date:   Thu, 24 Oct 2019 11:01:42 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <boris.brezillon@...labora.com>
CC:     <linux-arm-kernel@...ts.infradead.org>, <vigneshr@...com>,
        <geert+renesas@...der.be>, <andrew@...id.au>, <richard@....at>,
        <linux-kernel@...r.kernel.org>, <vz@...ia.com>,
        <marek.vasut@...il.com>, <jonas@...rbonn.se>,
        <linux-mtd@...ts.infradead.org>, <joel@....id.au>,
        <miquel.raynal@...tlin.com>, <matthias.bgg@...il.com>,
        <linux-mediatek@...ts.infradead.org>,
        <computersforpeace@...il.com>, <dwmw2@...radead.org>,
        <linux-aspeed@...ts.ozlabs.org>
Subject: Re: [PATCH v2 08/22] mtd: spi-nor: Rework write_enable/disable()



On 10/24/2019 09:04 AM, Boris Brezillon wrote:
> On Wed, 23 Oct 2019 23:39:31 +0000
> <Tudor.Ambarus@...rochip.com> wrote:
> 
>> On 10/10/2019 10:21 AM, Boris Brezillon wrote:
>>> External E-Mail
>>>
>>>
>>> On Tue, 24 Sep 2019 07:46:18 +0000
>>> <Tudor.Ambarus@...rochip.com> wrote:
>>>   
>>>> From: Tudor Ambarus <tudor.ambarus@...rochip.com>
>>>>
>>>> static int write_enable(struct spi_nor *nor)
>>>> static int write_disable(struct spi_nor *nor)
>>>> become
>>>> static int spi_nor_write_enable(struct spi_nor *nor)
>>>> static int spi_nor_write_disable(struct spi_nor *nor)
>>>>
>>>> Check for errors after each call to them. Move them up in the
>>>> file as the first SPI NOR Register Operations, to avoid further
>>>> forward declarations.  
>>>
>>> Same here, split that in 3 patches please.  
> 
> In order to keep the number of patch in this series small, I'd
> recommend doing all spi_nor_ prefixing in a patch, all function
> moves in another one and all error checking in a third patch, instead of
> splitting it per-function.
> 

If I do all the functions movement in one patch, the git diff output becomes
unreadable. I'll split patches where needed, for readability purposes.