linux-kernel - Re: [PATCH v2] pinctrl: sh-pfc: Do not use platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVQaCtWR9ZO7N-HKOZS1ivBNWssjqzV1B0XwSBkMFp8Ow@mail.gmail.com>
Date:   Thu, 24 Oct 2019 14:35:09 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] pinctrl: sh-pfc: Do not use platform_get_irq() to
 count interrupts

Hi Linus,

On Thu, Oct 24, 2019 at 2:07 PM Linus Walleij <linus.walleij@...aro.org> wrote:
> On Wed, Oct 16, 2019 at 4:26 PM Geert Uytterhoeven
> <geert+renesas@...der.be> wrote:
> > As platform_get_irq() now prints an error when the interrupt does not
> > exist, counting interrupts by looping until failure causes the printing
> > of scary messages like:
> >
> >     sh-pfc e6060000.pin-controller: IRQ index 0 not found
> >
> > Fix this by using the platform_irq_count() helper instead.
> >
> > Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> > Reviewed-by: Stephen Boyd <swboyd@...omium.org>
> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> > Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> > ---
> > v2:
> >   - Add Reviewed-by, Tested-by.
> >
> > Linus: Can you please take this one, as it is a fix for v5.4? Thx!
>
> I'm not sure the little error message counts as
> a regression, certainly users can live with it.

Several similar fixes have already made it upstream.
But the decision is up to you.

> Can't you just put it in your queue for the next kernel?

Sure, will do (after ELC-E), if you prefer.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds