[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdVnPREgPmn5TAmiqXSxuAYKv_AkQ6StZiDH79vKMRuBGg@mail.gmail.com>
Date: Fri, 25 Oct 2019 14:56:36 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Rob Herring <robh@...nel.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Simon Horman <horms+renesas@...ge.net.au>,
Phil Edworthy <phil.edworthy@...esas.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: serial: Move renesas,rzn1-uart into
the snps-dw-apb-uart binding
Hi Rob,
On Mon, Jan 14, 2019 at 6:30 PM Rob Herring <robh@...nel.org> wrote:
> The renesas,rzn1-uart binding only differs in compatible string from the
> snps-dw-apb-uart binding. Move it there, converting it to json-schema in
> the process.
>
> Cc: Phil Edworthy <phil.edworthy@...esas.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-serial@...r.kernel.org
> Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>
> Signed-off-by: Rob Herring <robh@...nel.org>
> --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> @@ -15,6 +15,11 @@ allOf:
> properties:
> compatible:
> oneOf:
> + - items:
> + - enum:
> + - renesas,r9a06g032-uart
> + - renesas,r9a06g033-uart
> + - const: renesas,rzn1-uart
> - items:
> - enum:
> - rockchip,px30-uart
With ARCH=arm and shmobile_defconfig, "make dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml"
complains:
arch/arm/boot/dts/r9a06g032-rzn1d400-db.dt.yaml: compatible:
['renesas,r9a06g032-uart', 'renesas,rzn1-uart', 'snps,dw-apb-uart'] is
not valid under any of the given schemas
arch/arm/boot/dts/r9a06g032-rzn1d400-db.dt.yaml: compatible:
['renesas,r9a06g032-uart', 'renesas,rzn1-uart', 'snps,dw-apb-uart'] is
not valid under any of the given schemas
arch/arm/boot/dts/r9a06g032-rzn1d400-db.dt.yaml: compatible:
['renesas,r9a06g032-uart', 'renesas,rzn1-uart', 'snps,dw-apb-uart'] is
not valid under any of the given schemas
Do you know what's wrong?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists