linux-kernel - Re: [PATCH v2 2/2] dt-bindings: serial: Move renesas,rzn1-uart into the snps-dw-apb-uart binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqLu3MAkY_YuSG=WtDCB3kwmQURstTwy2aVdkGv7m0JgMQ@mail.gmail.com>
Date:   Fri, 25 Oct 2019 09:38:37 -0500
From:   Rob Herring <robh@...nel.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Simon Horman <horms+renesas@...ge.net.au>,
        Phil Edworthy <phil.edworthy@...esas.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: serial: Move renesas,rzn1-uart into
 the snps-dw-apb-uart binding

On Fri, Oct 25, 2019 at 7:56 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Rob,
>
> On Mon, Jan 14, 2019 at 6:30 PM Rob Herring <robh@...nel.org> wrote:
> > The renesas,rzn1-uart binding only differs in compatible string from the
> > snps-dw-apb-uart binding. Move it there, converting it to json-schema in
> > the process.
> >
> > Cc: Phil Edworthy <phil.edworthy@...esas.com>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: linux-serial@...r.kernel.org
> > Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>
> > Signed-off-by: Rob Herring <robh@...nel.org>
>
> > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > @@ -15,6 +15,11 @@ allOf:
> >  properties:
> >    compatible:
> >      oneOf:
> > +      - items:
> > +          - enum:
> > +              - renesas,r9a06g032-uart
> > +              - renesas,r9a06g033-uart
> > +          - const: renesas,rzn1-uart
> >        - items:
> >            - enum:
> >                - rockchip,px30-uart
>
> With ARCH=arm and shmobile_defconfig, "make dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml"
> complains:
>
> arch/arm/boot/dts/r9a06g032-rzn1d400-db.dt.yaml: compatible:
> ['renesas,r9a06g032-uart', 'renesas,rzn1-uart', 'snps,dw-apb-uart'] is
> not valid under any of the given schemas
> arch/arm/boot/dts/r9a06g032-rzn1d400-db.dt.yaml: compatible:
> ['renesas,r9a06g032-uart', 'renesas,rzn1-uart', 'snps,dw-apb-uart'] is
> not valid under any of the given schemas
> arch/arm/boot/dts/r9a06g032-rzn1d400-db.dt.yaml: compatible:
> ['renesas,r9a06g032-uart', 'renesas,rzn1-uart', 'snps,dw-apb-uart'] is
> not valid under any of the given schemas
>
> Do you know what's wrong?

The addition doesn't allow for "snps,dw-apb-uart". Guess I relied on
the binding doc being accurate. So we need to either drop it from dts
files if the generic compatible is never useful (maybe simple cases
like earlycon?) or add it here.

Rob