linux-kernel - Re: [PATCH] mfd: db8500-prcmu: Support U8420-sysclk firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYQDkrRTzk5hrhvLhVZryHMH+Cqg6DVR6VAPG1DAdDesA@mail.gmail.com>
Date:   Sat, 26 Oct 2019 22:10:01 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Stephan Gerhold <stephan@...hold.net>
Cc:     Lee Jones <lee.jones@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        arm-soc <arm@...nel.org>
Subject: Re: [PATCH] mfd: db8500-prcmu: Support U8420-sysclk firmware

On Sat, Oct 26, 2019 at 4:37 PM Stephan Gerhold <stephan@...hold.net> wrote:

> >       irqchip_init();
> > +     prcmu_early_init();
> >       np = of_find_compatible_node(NULL, NULL, "stericsson,db8500-prcmu");
>
> Maybe it would make sense to give the struct device_node *np pointer as
> parameter to prcmu_early_init() to avoid duplicating the lookup of the
> device tree node there? But not sure if this is worth it.

I wanted to make the PRCMU driver more stand-alone, looking up
its own resources etc, so I prefer to keep it like this. The other
use in mach-ux500/cpu-db8500.c is the power domains that
should ideally also become a separate driver.

This is called very early on init_IRQ() -> machine->init_irq()
and I just don't know any better way to sneak in before
init_time(), else I would use it...

Fixed the rest!

Thanks a lot,
Linus Walleij