linux-kernel - Re: [Patch v2 1/2] lib/rbtree: set successor's parent unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191028092045.GC4114@hirez.programming.kicks-ass.net>
Date:   Mon, 28 Oct 2019 10:20:45 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Wei Yang <richardw.yang@...ux.intel.com>
Cc:     akpm@...ux-foundation.org, walken@...gle.com, dbueso@...e.de,
        tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [Patch v2 1/2] lib/rbtree: set successor's parent unconditionally

On Mon, Oct 28, 2019 at 10:14:41AM +0800, Wei Yang wrote:
> Both in Case 2 and 3, we exchange n and s. This mean no matter whether
> child2 is NULL or not, successor's parent should be assigned to node's.
> 
> This patch takes this step out to make it explicit and reduce the
> ambiguity.
> 
> Besides, this step reduces some symbol size like rb_erase().
> 
>    KERN_CONFIG       upstream       patched
>    OPT_FOR_PERF      877            870
>    OPT_FOR_SIZE      635            621
> 
> Signed-off-by: Wei Yang <richardw.yang@...ux.intel.com>

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>