linux-kernel - Re: [PATCH v2] cpuidle: not unset the driver if it already exist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3207655.LvExCM5pf1@kreacher>
Date:   Mon, 28 Oct 2019 16:22:02 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Zhenzhong Duan <zhenzhong.duan@...cle.com>
Cc:     linux-kernel@...r.kernel.org, daniel.lezcano@...aro.org,
        linux-pm@...r.kernel.org, mtosatti@...hat.com
Subject: Re: [PATCH v2] cpuidle: not unset the driver if it already exist

On Wednesday, October 23, 2019 3:57:14 AM CET Zhenzhong Duan wrote:
> __cpuidle_set_driver() check if there is an already exist driver and
> unset it before return with -EBUSY. The next call will succeed as it's
> just unset.
> 
> check if any of the CPUs in the mask have a driver different from drv
> already and if so return -EBUSY before updating any cpuidle_drivers
> per-CPU pointers.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@...cle.com>
> ---
> v2: update code logic per Rafael
> 
>  drivers/cpuidle/driver.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c
> index 80c1a83..acfce04 100644
> --- a/drivers/cpuidle/driver.c
> +++ b/drivers/cpuidle/driver.c
> @@ -62,24 +62,23 @@ static inline void __cpuidle_unset_driver(struct cpuidle_driver *drv)
>   * __cpuidle_set_driver - set per CPU driver variables for the given driver.
>   * @drv: a valid pointer to a struct cpuidle_driver
>   *
> - * For each CPU in the driver's cpumask, unset the registered driver per CPU
> - * to @drv.
> - *
> - * Returns 0 on success, -EBUSY if the CPUs have driver(s) already.
> + * Returns 0 on success, -EBUSY if any CPU in the cpumask have a driver
> + * different from drv already.
>   */
>  static inline int __cpuidle_set_driver(struct cpuidle_driver *drv)
>  {
>  	int cpu;
>  
>  	for_each_cpu(cpu, drv->cpumask) {
> +		struct cpuidle_driver *old_drv;
>  
> -		if (__cpuidle_get_cpu_driver(cpu)) {
> -			__cpuidle_unset_driver(drv);
> +		old_drv = __cpuidle_get_cpu_driver(cpu);
> +		if (old_drv && old_drv != drv)
>  			return -EBUSY;
> -		}
> +	}
>  
> +	for_each_cpu(cpu, drv->cpumask)
>  		per_cpu(cpuidle_drivers, cpu) = drv;
> -	}
>  
>  	return 0;
>  }
> 

Applied as 5.5 material, thanks!