linux-kernel - Re: [PATCH] staging: vc04_services: replace g_free_fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191028152108.bjliafudxn3llysv@linux-p48b>
Date:   Mon, 28 Oct 2019 08:21:08 -0700
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Stefan Wahren <wahrenst@....net>
Cc:     eric@...olt.net, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: vc04_services: replace g_free_fragments_mutex
 with spinlock

On Mon, 28 Oct 2019, Stefan Wahren wrote:

>Hi Davidlohr,
>
>Am 27.10.19 um 23:15 schrieb Davidlohr Bueso:
>> There seems no need to be using a semaphore, or a sleeping lock
>> in the first place: critical region is extremely short, does not
>> call into any blocking calls and furthermore lock and unlocking
>> operations occur in the same context.
>>
>> Get rid of another semaphore user by replacing it with a spinlock.
>>
>> Signed-off-by: Davidlohr Bueso <dave@...olabs.net>
>> ---
>> This is in an effort to further reduce semaphore users in the kernel.
>>
>thanks for this. Could please also send this to devel@...verdev.osuosl.org?

Ccing.

>
>I only need to know, has this been tested on the Raspberry Pi?

No testing has been done, I have no hardware to test this.

Thanks,
Davidlohr