linux-kernel - Re: [PATCH] cpufreq: Clarify the comment in cpufreq_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3398893.vxru0tI2Zt@kreacher>
Date:   Mon, 28 Oct 2019 16:23:28 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     linux-pm@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: Clarify the comment in cpufreq_set_policy()

On Tuesday, October 22, 2019 12:17:57 PM CET Viresh Kumar wrote:
> One of the responsibility of the ->verify() callback is to make sure
> that the policy's min frequency is <= max frequency as this isn't
> guaranteed by the QoS framework which gave us those values.
> 
> Update the comment in cpufreq_set_policy() to clarify that.
> 
> Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>  drivers/cpufreq/cpufreq.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 2e698b5f0f80..b4b5f11c2f1e 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -2384,7 +2384,10 @@ int cpufreq_set_policy(struct cpufreq_policy *policy,
>  	new_policy->min = freq_qos_read_value(&policy->constraints, FREQ_QOS_MIN);
>  	new_policy->max = freq_qos_read_value(&policy->constraints, FREQ_QOS_MAX);
>  
> -	/* verify the cpu speed can be set within this limit */
> +	/*
> +	 * Verify that the cpu speed can be set within this limit and make sure
> +	 * min <= max.
> +	 */
>  	ret = cpufreq_driver->verify(new_policy);
>  	if (ret)
>  		return ret;
> 

Applying for 5.5, thanks!