[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CALAqxLXqLUpew9XptiXZGodf5M3qyNmD-D1-2CHZ9PRfPTBRRQ@mail.gmail.com>
Date: Mon, 28 Oct 2019 11:39:03 -0700
From: John Stultz <john.stultz@...aro.org>
To: Christoph Hellwig <hch@...radead.org>
Cc: lkml <linux-kernel@...r.kernel.org>,
Sandeep Patil <sspatil@...gle.com>,
Laura Abbott <labbott@...hat.com>,
Benjamin Gaignard <benjamin.gaignard@...aro.org>,
Sumit Semwal <sumit.semwal@...aro.org>,
Liam Mark <lmark@...eaurora.org>,
Pratik Patel <pratikp@...eaurora.org>,
Brian Starkey <Brian.Starkey@....com>,
"Andrew F . Davis" <afd@...com>,
Andrew Morton <akpm@...ux-foundation.org>,
Yue Hu <huyue2@...ong.com>, Mike Rapoport <rppt@...ux.ibm.com>,
Chenbo Feng <fengc@...gle.com>,
Alistair Strachan <astrachan@...gle.com>,
Hridya Valsaraju <hridya@...gle.com>,
dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a module
On Mon, Oct 28, 2019 at 12:46 AM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Fri, Oct 25, 2019 at 11:48:33PM +0000, John Stultz wrote:
> > struct cma *dma_contiguous_default_area;
> > +EXPORT_SYMBOL(dma_contiguous_default_area);
>
> Please CC the dma maintainer. And no, you have no business using this.
Sure thing. And I'll look again to see why I was needing to pull that
one in to get it to build.
> Even if you did, internals like this should always be EXPORT_SYMBOL_GPL.
Certainly! My mistake here!
Thanks for the feedback!
-john
Powered by blists - more mailing lists