linux-kernel - Re: [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Oct 2019 12:12:31 -0700
From:   sspatil@...gle.com
To:     john.stultz@...aro.org, linux-kernel@...r.kernel.org,
        labbott@...hat.com, benjamin.gaignard@...aro.org,
        sumit.semwal@...aro.org, lmark@...eaurora.org,
        pratikp@...eaurora.org, Brian.Starkey@....com, afd@...com,
        akpm@...ux-foundation.org, huyue2@...ong.com, rppt@...ux.ibm.com,
        fengc@...gle.com, astrachan@...gle.com, hridya@...gle.com,
        dri-devel@...ts.freedesktop.org
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Laura Abbott <labbott@...hat.com>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Liam Mark <lmark@...eaurora.org>,
        Pratik Patel <pratikp@...eaurora.org>,
        Brian Starkey <Brian.Starkey@....com>,
        "Andrew F . Davis" <afd@...com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Yue Hu <huyue2@...ong.com>, Mike Rapoport <rppt@...ux.ibm.com>,
        Chenbo Feng <fengc@...gle.com>,
        Alistair Strachan <astrachan@...gle.com>,
        Hridya Valsaraju <hridya@...gle.com>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a
 module

On Fri, Oct 25, 2019 at 11:48:33PM +0000, John Stultz wrote:
> From: Sandeep Patil <sspatil@...gle.com>
> 
> Export cma_get_name, cma_alloc, cma_release, cma_for_each_area
> and dma_contiguous_default_area so that we can use these from
> the dmabuf cma heap when it is built as module.
> 
> Cc: Laura Abbott <labbott@...hat.com>
> Cc: Benjamin Gaignard <benjamin.gaignard@...aro.org>
> Cc: Sumit Semwal <sumit.semwal@...aro.org>
> Cc: Liam Mark <lmark@...eaurora.org>
> Cc: Pratik Patel <pratikp@...eaurora.org>
> Cc: Brian Starkey <Brian.Starkey@....com>
> Cc: Andrew F. Davis <afd@...com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Yue Hu <huyue2@...ong.com>
> Cc: Mike Rapoport <rppt@...ux.ibm.com>
> Cc: Chenbo Feng <fengc@...gle.com>
> Cc: Alistair Strachan <astrachan@...gle.com>
> Cc: Sandeep Patil <sspatil@...gle.com>
> Cc: Hridya Valsaraju <hridya@...gle.com>
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Sandeep Patil <sspatil@...gle.com>
> [jstultz: Rewrote commit message, added
>  dma_contiguous_default_area to the set of exported symbols]
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> ---
>  kernel/dma/contiguous.c | 1 +
>  mm/cma.c                | 5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c
> index 69cfb4345388..ff6cba63ea6f 100644
> --- a/kernel/dma/contiguous.c
> +++ b/kernel/dma/contiguous.c
> @@ -31,6 +31,7 @@
>  #endif
>  
>  struct cma *dma_contiguous_default_area;
> +EXPORT_SYMBOL(dma_contiguous_default_area);

I didn't need to do this for the (out-of-tree) ion cma heap [1].
Any reason why you had to?

Other than that, thanks for doing this John.

Acked-by: Sandeep Patil <sspatil@...gle.com>

- ssp

1] https://android-review.googlesource.com/c/kernel/common/+/1121591