linux-kernel - Re: [PATCH v4 1/2] dt-bindings: gpio: brcm: Add bindings for xgs-iproc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54ca79b4275e06b9ebf33450b068c914ed0217a7.camel@alliedtelesis.co.nz>
Date:   Mon, 28 Oct 2019 20:02:11 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     "robh+dt@...nel.org" <robh+dt@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "rjui@...adcom.com" <rjui@...adcom.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "sbranden@...adcom.com" <sbranden@...adcom.com>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: gpio: brcm: Add bindings for
 xgs-iproc

Hi Rob,

On Fri, 2019-10-25 at 12:12 -0500, Rob Herring wrote:
> On Thu, Oct 24, 2019 at 3:27 PM Chris Packham
> <chris.packham@...iedtelesis.co.nz> wrote:
> > 
> > This GPIO controller is present on a number of Broadcom switch ASICs
> > with integrated SoCs. It is similar to the nsp-gpio and iproc-gpio
> > blocks but different enough to require a separate driver.
> > 
> > Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> > ---
> > 
> > Notes:
> >     Changes in v4:
> >     - rename brcm,xgs-iproc.yaml -> brcm,xgs-iproc-gpio.yaml as suggested
> > 
> >     Changes in v3:
> >     - incorporate review comments from Rob and Bart
> > 
> >     Changes in v2:
> >     - Document as DT schema
> >     - Include ngpios, #gpio-cells and gpio-controller properties
> > 
> >  .../bindings/gpio/brcm,xgs-iproc-gpio.yaml    | 70 +++++++++++++++++++
> >  1 file changed, 70 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml
> > new file mode 100644
> > index 000000000000..ec1fd3a64aa2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml
> > @@ -0,0 +1,70 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/gpio/brcm,xgs-iproc.yaml#
> 
> Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml: $id:
> path/filename 'gpio/brcm,xgs-iproc.yaml' doesn't match actual filename
> 
> Otherwise,
> 
> Reviewed-by: Rob Herring <robh@...nel.org>

I'll send a quick v5 of just this patch with the minor correction and
your reviewed-by.