linux-kernel - Re: [PATCH] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Oct 2019 15:19:52 -0500
From:   Rob Herring <robh@...nel.org>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc:     "kishon@...com" <kishon@...com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema

On Mon, Oct 28, 2019 at 11:14 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@...esas.com> wrote:
>
> Hi Rob,
>
> Thank you for your review!
>
> > From: Rob Herring, Sent: Tuesday, October 29, 2019 10:57 AM
> >
> > On Fri, Oct 18, 2019 at 05:38:53PM +0900, Yoshihiro Shimoda wrote:
> > > Convert Renesas R-Car generation 3 USB 2.0 PHY bindings documentation
> > > to json-schema.
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> > > ---
> > >  .../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt |  70 --------------
> > >  .../devicetree/bindings/phy/renesas,usb2-phy.yaml  | 106 +++++++++++++++++++++
> > >  2 files changed, 106 insertions(+), 70 deletions(-)
> > >  delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> > >  create mode 100644 Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> >
> >
> > > diff --git a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > new file mode 100644
> > > index 00000000..0f109c2
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > @@ -0,0 +1,106 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/phy/renesas,usb2-phy.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Renesas R-Car generation 3 USB 2.0 PHY
> > > +
> > > +maintainers:
> > > +  - Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    oneOf:
> >
> > This:
>
> What does the "This:" mean?

I was referring to the 3 lines below. I was trying to be clear which
lines to replace with just 'const'.

> If I replaced the "oneOf:" with "This:",
> the following error happens when "make dt_binding_check":
>
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml
> warning: no schema found in file: Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> [snip]/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml: ignoring, error in schema 'compatible'
> Documentation/devicetree/bindings/Makefile:33: recipe for target 'Documentation/devicetree/bindings/processed-schema.yaml' failed
> make[1]: *** [Documentation/devicetree/bindings/processed-schema.yaml] Error 255
> Makefile:1263: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
>
> > > +      - items:
> > > +          - enum:
> > > +              - renesas,usb2-phy-r8a77470 # RZ/G1C
> >
> > You can simplify to just:
> >
> >          - const: renesas,usb2-phy-r8a77470 # RZ/G1C
>
> I'll fix it.