linux-kernel - RE: [PATCH] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYAPR01MB454465C8076E9F77420DB7DBD8600@TYAPR01MB4544.jpnprd01.prod.outlook.com>
Date:   Wed, 30 Oct 2019 02:28:57 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Rob Herring <robh@...nel.org>
CC:     "kishon@...com" <kishon@...com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH] dt-bindings: phy: renesas: usb2-phy: convert bindings to
 json-schema

Hi Rob,

> From: Rob Herring, Sent: Wednesday, October 30, 2019 5:20 AM
> 
> On Mon, Oct 28, 2019 at 11:14 PM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@...esas.com> wrote:
<snip>
> > > > diff --git a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > > new file mode 100644
> > > > index 00000000..0f109c2
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > > @@ -0,0 +1,106 @@
> > > > +# SPDX-License-Identifier: GPL-2.0-only
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/phy/renesas,usb2-phy.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Renesas R-Car generation 3 USB 2.0 PHY
> > > > +
> > > > +maintainers:
> > > > +  - Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> > > > +
> > > > +properties:
> > > > +  compatible:
> > > > +    oneOf:
> > >
> > > This:
> >
> > What does the "This:" mean?
> 
> I was referring to the 3 lines below. I was trying to be clear which
> lines to replace with just 'const'.

Thank you for the reply! I understood it.

Best regards,
Yoshihiro Shimoda

> > If I replaced the "oneOf:" with "This:",
> > the following error happens when "make dt_binding_check":
> >
> >   SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml
> > warning: no schema found in file: Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > [snip]/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml: ignoring, error in schema 'compatible'
> > Documentation/devicetree/bindings/Makefile:33: recipe for target
> 'Documentation/devicetree/bindings/processed-schema.yaml' failed
> > make[1]: *** [Documentation/devicetree/bindings/processed-schema.yaml] Error 255
> > Makefile:1263: recipe for target 'dt_binding_check' failed
> > make: *** [dt_binding_check] Error 2
> >
> > > > +      - items:
> > > > +          - enum:
> > > > +              - renesas,usb2-phy-r8a77470 # RZ/G1C
> > >
> > > You can simplify to just:
> > >
> > >          - const: renesas,usb2-phy-r8a77470 # RZ/G1C
> >
> > I'll fix it.