linux-kernel - Re: [PATCH] pstore: make 'pstore_choose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201910290940.E90A2D2B1D@keescook>
Date:   Tue, 29 Oct 2019 09:41:11 -0700
From:   Kees Cook <keescook@...omium.org>
To:     "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>
Cc:     linux-kernel@...ts.codethink.co.uk,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pstore: make 'pstore_choose_compression' static

On Wed, Oct 16, 2019 at 01:33:17PM +0100, Ben Dooks (Codethink) wrote:
> The pstore_choose_compression function is not exported
> so make it static to avoid the following sparse warning:
> 
> fs/pstore/platform.c:796:13: warning: symbol 'pstore_choose_compression' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

Oops! Yes, thank you. Applied to my for-next/pstore branch. :)

-Kees

> ---
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Anton Vorontsov <anton@...msg.org>
> Cc: Colin Cross <ccross@...roid.com>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: linux-kernel@...r.kernel.org
> ---
>  fs/pstore/platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
> index 3d7024662d29..d896457e7c11 100644
> --- a/fs/pstore/platform.c
> +++ b/fs/pstore/platform.c
> @@ -793,7 +793,7 @@ static void pstore_timefunc(struct timer_list *unused)
>  			  jiffies + msecs_to_jiffies(pstore_update_ms));
>  }
>  
> -void __init pstore_choose_compression(void)
> +static void __init pstore_choose_compression(void)
>  {
>  	const struct pstore_zbackend *step;
>  
> -- 
> 2.23.0
> 

-- 
Kees Cook