linux-kernel - Re: [PATCH] net: usb: lan78xx: Disable interrupts before calling generic_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191029164116.44px7mtwrauquurz@beryllium.lan>
Date:   Tue, 29 Oct 2019 17:41:16 +0100
From:   Daniel Wagner <dwagner@...e.de>
To:     Stefan Wahren <wahrenst@....net>
Cc:     netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Woojung Huh <woojung.huh@...rochip.com>,
        Marc Zyngier <maz@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Jisheng Zhang <Jisheng.Zhang@...aptics.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH] net: usb: lan78xx: Disable interrupts before calling
 generic_handle_irq()

Hi Stefan,

On Sun, Oct 27, 2019 at 01:14:41PM +0100, Stefan Wahren wrote:
> did you ever see this pseudo lan78xx-irqs fire? I examined
> /proc/interrupts on RPi 3B+ and always saw a 0.

# cat /proc/interrupts 
           CPU0       CPU1       CPU2       CPU3       
  2:         15         10         20         14  ARMCTRL-level   1 Edge      3f00b880.mailbox
 41:     127709     127690     127596     127783  ARMCTRL-level  41 Edge      3f980000.usb, dwc2_hsotg:usb1
 61:        219        208        183        192  ARMCTRL-level  61 Edge      ttyS1
 65:       1285       1340       2112       1483  ARMCTRL-level  88 Edge      mmc0
 71:         11         15         13         13  ARMCTRL-level  94 Edge      mmc1
147:       2823       2995       3648       3615  bcm2836-timer   1 Edge      arch_timer
148:          0          0          0          0  bcm2836-timer   3 Edge      kvm guest timer
150:          0          1          2          0  lan78xx-irqs  17 Edge      usb-001:004:01
IPI0:     11102      11331      12204      11011       Rescheduling interrupts
IPI1:        34        537        547        523       Function call interrupts
IPI2:         0          0          0          0       CPU stop interrupts
IPI3:         0          0          0          0       CPU stop (for crash dump) interrupts
IPI4:         0          0          0          0       Timer broadcast interrupts
IPI5:         0          0          0          0       IRQ work interrupts
IPI6:         0          0          0          0       CPU wake-up interrupts


Yes, this seems to work now fine with the current version. 

Thanks,
Daniel