linux-kernel - Re: [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Oct 2019 16:15:35 +0800
From:   Yunfeng Ye <yeyunfeng@...wei.com>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        <hushiyuan@...wei.com>,
        "linfeilong@...wei.com" <linfeilong@...wei.com>
Subject: Re: [PATCH v3] crypto: arm64/aes-neonbs - add return value of
 skcipher_walk_done() in __xts_crypt()



On 2019/10/31 16:13, Ard Biesheuvel wrote:
> On Thu, 31 Oct 2019 at 08:02, Yunfeng Ye <yeyunfeng@...wei.com> wrote:
>>
>> A warning is found by the static code analysis tool:
>>   "Identical condition 'err', second condition is always false"
>>
>> Fix this by adding return value of skcipher_walk_done().
>>
>> Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
>> Signed-off-by: Yunfeng Ye <yeyunfeng@...wei.com>
>> Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> 
> Please don't send the exact same patch twice, and when you feel the
> need to do so, just ask instead whether your patch was received or
> not.
> 
ok, thanks.

> I'm sure Herbert will pick it up shortly.
> 
>> ---
>> v2 -> v3:
>>  - add "Acked-by:"
>>
>> v1 -> v2:
>>  - update the subject and comment
>>  - add return value of skcipher_walk_done()
>>
>>  arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c
>> index ea873b8904c4..e3e27349a9fe 100644
>> --- a/arch/arm64/crypto/aes-neonbs-glue.c
>> +++ b/arch/arm64/crypto/aes-neonbs-glue.c
>> @@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
>>                         goto xts_tail;
>>
>>                 kernel_neon_end();
>> -               skcipher_walk_done(&walk, nbytes);
>> +               err = skcipher_walk_done(&walk, nbytes);
>>         }
>>
>>         if (err || likely(!tail))
>> --
>> 2.7.4.3
>>
>>
> 
> .
>