linux-kernel - Re: [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191101060654.w3jigumlcjep26mu@gondor.apana.org.au>
Date:   Fri, 1 Nov 2019 14:06:54 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Yunfeng Ye <yeyunfeng@...wei.com>
Cc:     davem@...emloft.net, catalin.marinas@....com, will@...nel.org,
        ard.biesheuvel@...aro.org, linux-crypto@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        hushiyuan@...wei.com,
        "linfeilong@...wei.com" <linfeilong@...wei.com>
Subject: Re: [PATCH v3] crypto: arm64/aes-neonbs - add return value of
 skcipher_walk_done() in __xts_crypt()

On Tue, Oct 22, 2019 at 04:11:18PM +0800, Yunfeng Ye wrote:
> A warning is found by the static code analysis tool:
>   "Identical condition 'err', second condition is always false"
> 
> Fix this by adding return value of skcipher_walk_done().
> 
> Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
> Signed-off-by: Yunfeng Ye <yeyunfeng@...wei.com>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> ---
> v2 -> v3:
>  - add "Acked-by:"
> 
> v1 -> v2:
>  - update the subject and comment
>  - add return value of skcipher_walk_done()
> 
>  arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt