linux-kernel - Re: [PATCH] seq_file: fix condition while loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191031140600.GL26530@ZenIV.linux.org.uk>
Date:   Thu, 31 Oct 2019 14:06:00 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Yi Li <yili@...hong.com>
Cc:     linux-fsdevel@...r.kernel.org, Yi Li <yilikernel@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] seq_file: fix condition while loop

On Thu, Oct 31, 2019 at 07:38:21PM +0800, Yi Li wrote:
> From: Yi Li <yilikernel@...il.com>
> 
> Use the break condition of loop body.
> PTR_ERR has some meanings when p is illegal,and return 0 when p is null.
> set the err = 0 on the next iteration if err > 0.

IDGI.  PTR_ERR() is not going to cause any kind of undefined behaviour for
any valid pointer and it's trivial to evaluate.  What's the point?