linux-kernel - Re: [PATCH] seq_file: fix condition while loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfdMYDQSKp4AeeBwy5R8qmmtdke693rwArzMf6ay5reemRmRg@mail.gmail.com>
Date:   Fri, 1 Nov 2019 13:48:06 +0800
From:   李义 <yilikernel@...il.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Yi Li <yili@...hong.com>, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] seq_file: fix condition while loop

On Thu, Oct 31, 2019 at 10:06 PM Al Viro <viro@...iv.linux.org.uk> wrote:
>
> On Thu, Oct 31, 2019 at 07:38:21PM +0800, Yi Li wrote:
> > From: Yi Li <yilikernel@...il.com>
> >
> > Use the break condition of loop body.
> > PTR_ERR has some meanings when p is illegal,and return 0 when p is null.
> > set the err = 0 on the next iteration if err > 0.
>
> IDGI.  PTR_ERR() is not going to cause any kind of undefined behaviour for
> any valid pointer and it's trivial to evaluate.  What's the point?
This patch doesn't introduce any functional changes.
Sorry for the noise..