linux-kernel - Re: [RESEND PATCH] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191031150925.GA27535@willie-the-truck>
Date:   Thu, 31 Oct 2019 15:09:27 +0000
From:   Will Deacon <will@...nel.org>
To:     linux-media@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, andreyknvl@...gle.com,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Kostya Serebryany <kcc@...gle.com>, stable@...r.kernel.org
Subject: Re: [RESEND PATCH] media: uvc: Avoid cyclic entity chains due to
 malformed USB descriptors

On Wed, Oct 16, 2019 at 08:58:00PM +0100, Will Deacon wrote:
> Add a check before adding an entity to a chain list to ensure that the
> entity is not already part of a chain.
> 
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Dmitry Vyukov <dvyukov@...gle.com>
> Cc: Kostya Serebryany <kcc@...gle.com>
> Cc: <stable@...r.kernel.org>
> Fixes: c0efd232929c ("V4L/DVB (8145a): USB Video Class driver")
> Reported-by: Andrey Konovalov <andreyknvl@...gle.com>
> Link: https://lore.kernel.org/linux-media/CAAeHK+z+Si69jUR+N-SjN9q4O+o5KFiNManqEa-PjUta7EOb7A@mail.gmail.com/
> Signed-off-by: Will Deacon <will@...nel.org>
> ---
> 
> Resending since I don't think any material changes are required to address
> the comments on the previous posting:
> 
> http://lkml.kernel.org/r/20191002112753.21630-1-will@kernel.org
> 
>  drivers/media/usb/uvc/uvc_driver.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)

Gentle nudge on this patch, since I don't see it in -next and I've not
received any comments on it for a while.

Cheers,

Will