linux-kernel - Re: [RFC PATCH v2] f2fs: support data compression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33c09ea0-b521-77b7-dd84-a3ede003a793@huawei.com>
Date:   Fri, 1 Nov 2019 18:05:44 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Jaegeuk Kim <jaegeuk@...nel.org>
CC:     <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>, <chao@...nel.org>
Subject: Re: [RFC PATCH v2] f2fs: support data compression

On 2019/11/1 0:01, Jaegeuk Kim wrote:
>> +f2fs-$(CONFIG_FS_COMPRESSION) += compress.o
> CONFIG_F2FS_FS_COMPRESSION?

Fixed.

> 
>> +#ifdef F2FS_FS_COMPRESSION
> Do we need this?

Ditto.

> 
>> +bool f2fs_is_compress_backend_ready(struct inode *inode)
>> +{
>> +	if (!f2fs_compressed_file(inode))
>> +		return true;
> #ifdef F2FS_FS_COMPRESSION
>> +	return f2fs_cops[F2FS_I(inode)->i_compress_algorithm];
> #else
> 	return -EOPNOTSUPP;
> #endif

Ditto, I kept return value as boolean.

>