linux-kernel - Re: [PATCH RFC 1/6] perf/x86: Add perf text poke event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20191101100611.GV4131@hirez.programming.kicks-ass.net>
Date:   Fri, 1 Nov 2019 11:06:11 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Mike Leach <mike.leach@...aro.org>
Cc:     Leo Yan <leo.yan@...aro.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org,
        x86@...nel.org
Subject: Re: [PATCH RFC 1/6] perf/x86: Add perf text poke event

On Thu, Oct 31, 2019 at 12:29:15PM +0000, Mike Leach wrote:
> On Thu, 31 Oct 2019 at 07:31, Leo Yan <leo.yan@...aro.org> wrote:

> > > Since all instructions (with the possible exception of RET) are
> > > unconditional branch instructions: NOP, JMP, CALL. It makes no read
> > > difference to the argument below.
> > >
> > > ( I'm thinking RET might be special in that it reads the return address
> > > from the stack and therefore must emit the whole IP into the stream, as
> > > we cannot know the stack state )
> >
> > To be honest, I don't have knowledge what's the exactly format for 'ret'
> > in CoreSight trace; so would like to leave this to Mike.
> >
> 
> For ETM trace we do not have to output the entire address into he stream if:
> - address compression allows us to emit only the changed ls bit from the
> last address.
> - the address is identical to one of the last three addresses emitted ( we
> just emit a ‘same address encoding’
> - we are using return stack compression and the address is top of the
> return stack (we emit nothing and the decoder gets the address from its own
> mode, of the return stack)

Cute. I don't actually know what PT does, but I figured there had to at
least be the option to provide more information.