linux-kernel - Re: [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7E1B5E17-FF35-472B-8316-D4C01085BAE4@oracle.com>
Date:   Fri, 1 Nov 2019 09:36:27 -0400
From:   Chuck Lever <chuck.lever@...cle.com>
To:     Mao Wenan <maowenan@...wei.com>
Cc:     Bruce Fields <bfields@...hat.com>,
        Trond Myklebust <trond.myklebust@...marydata.com>,
        Dros Adamson <dros@...marydata.com>,
        jeff.layton@...marydata.com, richard.sharpe@...marydata.com,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares
 is never used.

Hi Mao-

> On Nov 1, 2019, at 7:40 AM, Mao Wenan <maowenan@...wei.com> wrote:
> 
> The declarations were introduced with the file, but the declared
> variables were not used.
> 
> Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")

I'm not sure a Fixes: tag is necessary here? 65294c1f2c5e
works fine without this change, and it's not something we
would need to backport into stable kernels.

This is more of a clean up patch.


> Signed-off-by: Mao Wenan <maowenan@...wei.com>
> ---
> fs/nfsd/filecache.c | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index ef55e9b..32a9bf2 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -685,8 +685,6 @@ nfsd_file_cache_purge(struct net *net)
> void
> nfsd_file_cache_shutdown(void)
> {
> -	LIST_HEAD(dispose);
> -
> 	set_bit(NFSD_FILE_SHUTDOWN, &nfsd_file_lru_flags);
> 
> 	lease_unregister_notifier(&nfsd_file_lease_notifier);
> -- 
> 2.7.4
> 

--
Chuck Lever