linux-kernel - Re: [PATCH] Coccinelle: zalloc-simple: Adjust a message construction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 3 Nov 2019 20:39:26 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Markus Elfring <Markus.Elfring@....de>
cc:     cocci@...teme.lip6.fr, kernel-janitors@...r.kernel.org,
        Christoph Hellwig <hch@....de>,
        Enrico Weigelt <lkml@...ux.net>,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Coccinelle: zalloc-simple: Adjust a message
 construction



On Sun, 3 Nov 2019, Markus Elfring wrote:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 3 Nov 2019 20:00:30 +0100
>
> * Simplify a message construction in a Python script rule
>   for the semantic patch language.

The benefit is what?

julia

>
> * Delete also a duplicate space character then.
>
> Fixes: dfd32cad146e3624970eee9329e99d2c6ef751b3 ("dma-mapping: remove dma_zalloc_coherent()")
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  scripts/coccinelle/api/alloc/zalloc-simple.cocci | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccinelle/api/alloc/zalloc-simple.cocci b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> index 26cda3f48f01..c14eae1f3010 100644
> --- a/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> +++ b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> @@ -217,8 +217,10 @@ p << r2.p;
>  x << r2.x;
>  @@
>
> -msg="WARNING: dma_alloc_coherent use in %s already zeroes out memory,  so memset is not needed" % (x)
> -coccilib.report.print_report(p[0], msg)
> +coccilib.report.print_report(p[0],
> +                             "WARNING: dma_alloc_coherent use in "
> +                             + x
> +                             + " already zeroes out memory. Thus memset is not needed.")
>
>  //-----------------------------------------------------------------
>  @r3 depends on org || report@
> --
> 2.23.0
>
>