[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <266047531.90300507.1572880575232.JavaMail.zimbra@kalray.eu>
Date: Mon, 4 Nov 2019 16:16:15 +0100 (CET)
From: Marta Rybczynska <mrybczyn@...ray.eu>
To: Charles Machalow <csm10495@...il.com>
Cc: Christoph Hellwig <hch@....de>,
linux-nvme <linux-nvme@...ts.infradead.org>,
kbusch <kbusch@...nel.org>, axboe <axboe@...com>,
Sagi Grimberg <sagi@...mberg.me>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64's result field.
----- On 4 Nov, 2019, at 16:01, Charles Machalow csm10495@...il.com wrote:
> Yes. The idea is just to change the 64 IOCTL structure so it lines up
> with the old ones so that the same struct can be used from userspace.
> Right now the first 32 of 64's result doesn't line up with the old
> result field.
>
> - Charlie Scott Machalow
OK, then this will work on all architectures I know:
struct nvme_passthru_cmd64 {
__u8 opcode;
__u8 flags;
__u16 rsvd1;
__u32 nsid;
__u32 cdw2;
__u32 cdw3;
__u64 metadata;
__u64 addr;
__u32 metadata_len;
__u32 data_len;
__u32 cdw10;
__u32 cdw11;
__u32 cdw12;
__u32 cdw13;
__u32 cdw14;
__u32 cdw15;
__u32 timeout_ms;
__u32 rsvd2;
__u64 result;
};
Marta
Powered by blists - more mailing lists