linux-kernel - Re: [PATCH 2/2] net: phy: dp83869: Add TI dp83869 phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d5cb879-b3a2-545f-7f74-0f1f1e6380bb@gmail.com>
Date:   Tue, 5 Nov 2019 12:05:25 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Dan Murphy <dmurphy@...com>,
        Heiner Kallweit <hkallweit1@...il.com>, andrew@...n.ch,
        davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] net: phy: dp83869: Add TI dp83869 phy

On 11/5/19 12:02 PM, Dan Murphy wrote:
int ret, val;
>>> +
>>> +    if (!phydev->priv) {
>>> +        dp83869 = devm_kzalloc(&phydev->mdio.dev, sizeof(*dp83869),
>>> +                       GFP_KERNEL);
>> This belongs into the probe callback.
> probe callback?  Why do I need a probe function?

To allocate your driver private memory and do that just once,
config_init() can be called multiple times through the lifetime of your
PHY device driver, including but not limited to: phy_connect(),
phy_init_hw(), phy_resume() etc. etc.
-- 
Florian