linux-kernel - Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191105165723.GD8309@piout.net>
Date:   Tue, 5 Nov 2019 17:57:23 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc:     mazziesaccount@...il.com, Lee Jones <lee.jones@...aro.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

On 05/11/2019 17:53:18+0100, Alexandre Belloni wrote:
> On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > When RTC is used in 24H mode (and it is by this driver) the maximum
> > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > 
> > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> > ---
> >  include/linux/mfd/rohm-bd70528.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> Applied, thanks.
> 

Actually, is there any point in doing that since "rtc: bd70528 add
BD71828 support" will conflict with it and correct the issue anyway?

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com