linux-kernel - Re: [PATCH 3/5] crypto: caam - convert JR API to use struct caam_drv_private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201911061625.gWhNCxan%lkp@intel.com>
Date:   Wed, 6 Nov 2019 17:04:18 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-crypto@...r.kernel.org,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        Chris Healy <cphealy@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Horia Geantă <horia.geanta@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Iuliana Prodan <iuliana.prodan@....com>, linux-imx@....com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] crypto: caam - convert JR API to use struct
 caam_drv_private_jr

Hi Andrey,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on cryptodev/master]
[also build test WARNING on v5.4-rc6 next-20191105]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Andrey-Smirnov/CAAM-JR-lifecycle/20191106-090151
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/crypto/caam/caamalg_qi2.c:15:0:
>> drivers/crypto/caam/key_gen.h:44:28: warning: 'struct caam_drv_private_jr' declared inside parameter list will not be visible outside of this definition or declaration
    void split_key_done(struct caam_drv_private_jr *jr, u32 *desc, u32 err,
                               ^~~~~~~~~~~~~~~~~~~
   drivers/crypto/caam/key_gen.h:47:26: warning: 'struct caam_drv_private_jr' declared inside parameter list will not be visible outside of this definition or declaration
    int gen_split_key(struct caam_drv_private_jr *jr, u8 *key_out,
                             ^~~~~~~~~~~~~~~~~~~

vim +44 drivers/crypto/caam/key_gen.h

    43	
  > 44	void split_key_done(struct caam_drv_private_jr *jr, u32 *desc, u32 err,
    45			    void *context);
    46	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (70262 bytes)