linux-kernel - Re: [PATCH] reset: Free struct reset_control_array in reset_control_array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <412b74046c51be6d1228758624b8577453806758.camel@pengutronix.de>
Date:   Wed, 06 Nov 2019 10:06:45 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Jyri Sarha <jsarha@...com>, linux-kernel@...r.kernel.org
Cc:     tomi.valkeinen@...com, colin.king@...onical.com, treding@...dia.com
Subject: Re: [PATCH] reset: Free struct reset_control_array in
 reset_control_array_put()

On Mon, 2019-11-04 at 21:03 +0200, Jyri Sarha wrote:
> On 04/11/2019 18:30, Philipp Zabel wrote:
> > Hi Jyri,
> > 
> > On Mon, 2019-11-04 at 18:24 +0200, Jyri Sarha wrote:
> > > Fix memory leak in devm_reset_control_array_get(). Free also the
> > > struct reset_control_array pointer in reset_control_array_put() not
> > > only the reset-controls stored in it.
> > > 
> > > Reported-by: Tomi Valkeinen <tomi.valkeinen@...com>
> > > Signed-off-by: Jyri Sarha <jsarha@...com>
> > > ---
> > >  drivers/reset/core.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> > > index 213ff40dda11..85d9676ee969 100644
> > > --- a/drivers/reset/core.c
> > > +++ b/drivers/reset/core.c
> > > @@ -748,6 +748,8 @@ static void reset_control_array_put(struct reset_control_array *resets)
> > >  	for (i = 0; i < resets->num_rstcs; i++)
> > >  		__reset_control_put_internal(resets->rstc[i]);
> > >  	mutex_unlock(&reset_list_mutex);
> > > +
> > > +	kfree(resets);
> > >  }
> > >  
> > >  /**
> > 
> > Thank you, this just got fixed in 532f9cd6ee99 ("reset: Fix memory leak
> > in reset_control_array_put()").
> > 
> 
> Ok, sorry. I just checked the mainline, not the mailing lists etc.

No worries, that's perfectly fine. Just letting you know why this patch
isn't picked up.

regards
Philipp