linux-kernel - Re: [PATCH 4.19 059/149] iio: fix center temperature of bmc150-accel-core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191106094138.62qkvhfpyf5brits@ucw.cz>
Date:   Wed, 6 Nov 2019 10:41:38 +0100
From:   Pavel Machek <pavel@....cz>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Pascal Bouwmann <bouwmann@...-tec.de>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 059/149] iio: fix center temperature of
 bmc150-accel-core

> From: Pascal Bouwmann <bouwmann@...-tec.de>
> 
> [ Upstream commit 6c59a962e081df6d8fe43325bbfabec57e0d4751 ]
> 
> The center temperature of the supported devices stored in the constant
> BMC150_ACCEL_TEMP_CENTER_VAL is not 24 degrees but 23 degrees.
> 
> It seems that some datasheets were inconsistent on this value leading
> to the error.  For most usecases will only make minor difference so
> not queued for stable.
> 
> Signed-off-by: Pascal Bouwmann <bouwmann@...-tec.de>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>

Minor miscalibration, and author specifically states it should not be
queued for stable. Yet, Sasha goes and queues it for stable. Why?

       	   	   	      	       	      	     	     Pavel

> +++ b/drivers/iio/accel/bmc150-accel-core.c
> @@ -125,7 +125,7 @@
>  #define BMC150_ACCEL_SLEEP_1_SEC		0x0F
>  
>  #define BMC150_ACCEL_REG_TEMP			0x08
> -#define BMC150_ACCEL_TEMP_CENTER_VAL		24
> +#define BMC150_ACCEL_TEMP_CENTER_VAL		23
>  
>  #define BMC150_ACCEL_AXIS_TO_REG(axis)	(BMC150_ACCEL_REG_XOUT_L + (axis * 2))
>  #define BMC150_AUTO_SUSPEND_DELAY_MS		2000
> -- 
> 2.20.1
> 
>