linux-kernel - Re: [PATCH][next] xfs: remove redundant assignment to variable error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbb99652-c6b2-c81c-128d-6d85be04fddc@canonical.com>
Date:   Wed, 6 Nov 2019 15:59:44 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>
Cc:     linux-xfs@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] xfs: remove redundant assignment to variable error

On 06/11/2019 15:56, Darrick J. Wong wrote:
> On Wed, Nov 06, 2019 at 03:52:48PM +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> Variable error is being initialized with a value that is never read
>> and is being re-assigned a couple of statements later on. The
>> assignment is redundant and hence can be removed.
>>
>> Addresses-Coverity: ("Unused value")
> 
> Er... is there a coverity id that goes with this?

Unfortunately it is a private one, so it does not make sense to use it.

> 
> Patch looks fine otherwise.
> 
> --D
> 
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>>  fs/xfs/xfs_super.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
>> index b3188ea49413..2302f67d1a18 100644
>> --- a/fs/xfs/xfs_super.c
>> +++ b/fs/xfs/xfs_super.c
>> @@ -1362,7 +1362,7 @@ xfs_fc_fill_super(
>>  {
>>  	struct xfs_mount	*mp = sb->s_fs_info;
>>  	struct inode		*root;
>> -	int			flags = 0, error = -ENOMEM;
>> +	int			flags = 0, error;
>>  
>>  	mp->m_super = sb;
>>  
>> -- 
>> 2.20.1
>>