linux-kernel - Re: [PATCH][next] xfs: remove redundant assignment to variable error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a77fff95-0591-bcca-2541-3fd68c0da908@sandeen.net>
Date:   Wed, 6 Nov 2019 10:19:18 -0600
From:   Eric Sandeen <sandeen@...deen.net>
To:     Colin Ian King <colin.king@...onical.com>,
        "Darrick J. Wong" <darrick.wong@...cle.com>
Cc:     linux-xfs@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] xfs: remove redundant assignment to variable error



On 11/6/19 9:59 AM, Colin Ian King wrote:
> On 06/11/2019 15:56, Darrick J. Wong wrote:
>> On Wed, Nov 06, 2019 at 03:52:48PM +0000, Colin King wrote:
>>> From: Colin Ian King <colin.king@...onical.com>
>>>
>>> Variable error is being initialized with a value that is never read
>>> and is being re-assigned a couple of statements later on. The
>>> assignment is redundant and hence can be removed.
>>>
>>> Addresses-Coverity: ("Unused value")
>>
>> Er... is there a coverity id that goes with this?
> 
> Unfortunately it is a private one, so it does not make sense to use it.

If it's not in the upstream coverity scan (and AFAICT it's not),
it makes no sense to reference coverity in the commit log.
It's not useful to anyone IMHO.

-Eric