linux-kernel - Re: [PATCH v4 00/10] Rework REFCOUNT_FULL using atomic_fetch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191107130059.GB12705@willie-the-truck>
Date:   Thu, 7 Nov 2019 13:00:59 +0000
From:   Will Deacon <will@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Elena Reshetova <elena.reshetova@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Hanjun Guo <guohanjun@...wei.com>,
        Jan Glauber <jglauber@...vell.com>
Subject: Re: [PATCH v4 00/10] Rework REFCOUNT_FULL using atomic_fetch_*
 operations

On Wed, Oct 30, 2019 at 11:40:56AM -0700, Kees Cook wrote:
> On Wed, Oct 30, 2019 at 02:30:25PM +0000, Will Deacon wrote:
> > Hi all,
> > 
> > This is version four of the patches I previously posted here:
> > 
> >   v1: https://lkml.kernel.org/r/20190802101000.12958-1-will@kernel.org
> >   v2: https://lkml.kernel.org/r/20190827163204.29903-1-will@kernel.org
> >   v3: https://lkml.kernel.org/r/20191007154703.5574-1-will@kernel.org
> > 
> > Changes since v3 include:
> > 
> >   - Add description of racy behaviour include/linux/refcount.h
> >   - Fix saturation behaviour in refcount_sub_and_test()
> >   - Added Acks and Tested-bys
> 
> Thanks again for this! I think this series is in good shape; I'm glad we
> can sanely expand these protections.

Cheers, Kees.

Peter -- are you ok with this version? I think I've addressed all of your
concerns from v3, including the addition of ASCII-art to explain the
saturation behaviour (I can use .rst instead if you prefer).

Will