[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55258ebe-a341-57e5-dd9a-e8e719d899a4@codeaurora.org>
Date: Fri, 8 Nov 2019 09:20:13 +0530
From: Rajendra Nayak <rnayak@...eaurora.org>
To: Stephen Boyd <swboyd@...omium.org>, agross@...nel.org,
bjorn.andersson@...aro.org, robh+dt@...nel.org
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, mka@...omium.org,
Maulik Shah <mkshah@...eaurora.org>
Subject: Re: [PATCH v4 06/14] arm64: dts: qcom: sc7180: Add rpmh-rsc node
On 11/7/2019 11:23 PM, Stephen Boyd wrote:
> Quoting Rajendra Nayak (2019-11-05 22:50:09)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> index 61250560c7ef..98c8ab7d613c 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> @@ -387,6 +388,24 @@
>> status = "disabled";
>> };
>> };
>> +
>> + apps_rsc: rsc@...00000 {
>
> The node name is non-standard. This has been a problem since sdm845
> though so it would be nice if we can invent some new name for this that
> is standard at some point in the future.
>
>> + label = "apps_rsc";
>
> Can we remove this property? The value seems minimal given that we can
> use the dev_name() and get the address in there instead of using a label.
Sure, i'll remove it.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Powered by blists - more mailing lists