linux-kernel - Re: [PATCH v9 11/22] clk: tegra: clk-dfll: Add suspend and resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f644adda-dc6b-9b7e-3fc2-94091a38c99a@gmail.com>
Date:   Sat, 9 Nov 2019 02:38:17 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Stephen Boyd <sboyd@...nel.org>,
        Sowjanya Komatineni <skomatineni@...dia.com>,
        jason@...edaemon.net, jonathanh@...dia.com,
        linus.walleij@...aro.org, marc.zyngier@....com,
        mark.rutland@....com, stefan@...er.ch, tglx@...utronix.de,
        thierry.reding@...il.com
Cc:     pdeschrijver@...dia.com, pgaikwad@...dia.com,
        linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org,
        jckuo@...dia.com, josephl@...dia.com, talho@...dia.com,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        mperttunen@...dia.com, spatra@...dia.com, robh+dt@...nel.org,
        devicetree@...r.kernel.org, rjw@...ysocki.net,
        viresh.kumar@...aro.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v9 11/22] clk: tegra: clk-dfll: Add suspend and resume
 support

09.11.2019 00:20, Stephen Boyd пишет:
> Quoting Sowjanya Komatineni (2019-08-16 12:41:56)
>> diff --git a/drivers/clk/tegra/clk-dfll.c b/drivers/clk/tegra/clk-dfll.c
>> index f8688c2ddf1a..c051d92c2bbf 100644
>> --- a/drivers/clk/tegra/clk-dfll.c
>> +++ b/drivers/clk/tegra/clk-dfll.c
>> @@ -1487,6 +1487,7 @@ static int dfll_init(struct tegra_dfll *td)
>>         td->last_unrounded_rate = 0;
>>  
>>         pm_runtime_enable(td->dev);
>> +       pm_runtime_irq_safe(td->dev);
> 
> Why irq_safe? It would be good to mention it in the commit text or
> something.

That's a good catch. It was somewhat relevant for some older version of
this patch, but should be irrelevant now.

[snip]