linux-kernel - Re: [PATCH v4 05/17] platform: chrome: cros_ec: Do not attempt to register a non-positive IRQ number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Nov 2019 10:29:13 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Jonathan Cameron <jic23@...nel.org>,
        Gwendal Grignou <gwendal@...omium.org>
Cc:     briannorris@...omium.org, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, lee.jones@...aro.org, bleung@...omium.org,
        dianders@...omium.org, groeck@...omium.org,
        fabien.lahoudere@...labora.com, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org, Enrico Granata <egranata@...omium.org>
Subject: Re: [PATCH v4 05/17] platform: chrome: cros_ec: Do not attempt to
 register a non-positive IRQ number



On 10/11/19 13:17, Jonathan Cameron wrote:
> On Tue,  5 Nov 2019 14:26:40 -0800
> Gwendal Grignou <gwendal@...omium.org> wrote:
> 
>> Add a layer of sanity checking to cros_ec_register against attempting to
>> register IRQ values that are not strictly greater than 0.
>>
>> Signed-off-by: Enrico Granata <egranata@...omium.org>
>> Signed-off-by: Gwendal Grignou <gwendal@...omium.org>
> 
> This strikes me as something that could be a potential fix to backport?
> Any known cases of a negative irq getting to here or is this a by
> inspection thing?
> 
> Otherwise seems obviously correct.
> Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> 

Looks good to me:

Acked-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

Thanks,
 Enric

> Jonathan
> 
>> ---
>> No changes in v4, v3.
>> Changes in v2:
>>   Remove dual Enrico's signature.
>>
>>  drivers/platform/chrome/cros_ec.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
>> index 925f84dbf621..d3dfa27171e6 100644
>> --- a/drivers/platform/chrome/cros_ec.c
>> +++ b/drivers/platform/chrome/cros_ec.c
>> @@ -149,7 +149,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
>>  		return err;
>>  	}
>>  
>> -	if (ec_dev->irq) {
>> +	if (ec_dev->irq > 0) {
>>  		err = devm_request_threaded_irq(dev, ec_dev->irq,
>>  						ec_irq_handler,
>>  						ec_irq_thread,
>