linux-kernel - Re: [patch V2 11/16] x86/ioperm: Share I/O bitmap if identical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrVXV61hN__tf-TakJCLnM6rVZ-5x7U2eeojadovhk6AJg@mail.gmail.com>
Date:   Tue, 12 Nov 2019 10:12:14 -0800
From:   Andy Lutomirski <luto@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, X86 ML <x86@...nel.org>,
        Linus Torvalds <torvalds@...uxfoundation.org>,
        Andy Lutomirski <luto@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Willy Tarreau <w@....eu>, Juergen Gross <jgross@...e.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [patch V2 11/16] x86/ioperm: Share I/O bitmap if identical

On Mon, Nov 11, 2019 at 2:35 PM Thomas Gleixner <tglx@...utronix.de> wrote:
>
> The I/O bitmap is duplicated on fork. That's wasting memory and slows down
> fork. There is no point to do so. As long as the bitmap is not modified it
> can be shared between threads and processes.
>
> Add a refcount and just share it on fork. If a task modifies the bitmap
> then it has to do the duplication if and only if it is shared.
>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
> V2: New patch
> ---
>  arch/x86/include/asm/iobitmap.h |    5 +++++
>  arch/x86/kernel/ioport.c        |   38 ++++++++++++++++++++++++++++++++------
>  arch/x86/kernel/process.c       |   39 ++++++---------------------------------
>  3 files changed, 43 insertions(+), 39 deletions(-)
>
> --- a/arch/x86/include/asm/iobitmap.h
> +++ b/arch/x86/include/asm/iobitmap.h
> @@ -2,10 +2,12 @@
>  #ifndef _ASM_X86_IOBITMAP_H
>  #define _ASM_X86_IOBITMAP_H
>
> +#include <linux/refcount.h>
>  #include <asm/processor.h>
>
>  struct io_bitmap {
>         u64                     sequence;
> +       refcount_t              refcnt;
>         unsigned int            io_bitmap_max;
>         union {
>                 unsigned long   bits[IO_BITMAP_LONGS];
> @@ -13,6 +15,9 @@ struct io_bitmap {
>         };
>  };
>
> +struct task_struct;
> +
> +void io_bitmap_share(struct task_struct *tsk);
>  void io_bitmap_exit(void);
>
>  void tss_update_io_bitmap(void);
> --- a/arch/x86/kernel/ioport.c
> +++ b/arch/x86/kernel/ioport.c
> @@ -16,6 +16,17 @@
>
>  static atomic64_t io_bitmap_sequence;
>
> +void io_bitmap_share(struct task_struct *tsk)
> + {
> +       /*
> +        * Take a refcount on current's bitmap. It can be used by
> +        * both tasks as long as none of them changes the bitmap.
> +        */
> +       refcount_inc(&current->thread.io_bitmap->refcnt);
> +       tsk->thread.io_bitmap = current->thread.io_bitmap;
> +       set_tsk_thread_flag(tsk, TIF_IO_BITMAP);
> +}
> +
>  void io_bitmap_exit(void)
>  {
>         struct io_bitmap *iobm = current->thread.io_bitmap;
> @@ -25,7 +36,8 @@ void io_bitmap_exit(void)
>         clear_thread_flag(TIF_IO_BITMAP);
>         tss_update_io_bitmap();
>         preempt_enable();
> -       kfree(iobm);
> +       if (iobm && refcount_dec_and_test(&iobm->refcnt))
> +               kfree(iobm);
>  }
>
>  /*
> @@ -59,8 +71,26 @@ long ksys_ioperm(unsigned long from, uns
>                         return -ENOMEM;
>
>                 memset(iobm->bits, 0xff, sizeof(iobm->bits));
> +               refcount_set(&iobm->refcnt, 1);
> +       }
> +
> +       /*
> +        * If the bitmap is not shared, then nothing can take a refcount as
> +        * current can obviously not fork at the same time. If it's shared
> +        * duplicate it and drop the refcount on the original one.
> +        */
> +       if (refcount_read(&iobm->refcnt) > 1) {
> +               iobm = kmemdup(iobm, sizeof(*iobm), GFP_KERNEL);
> +               if (!iobm)
> +                       return -ENOMEM;
> +               io_bitmap_exit();

And change the refcount to 1?

>         }
>

Otherwise:

Acked-by: Andy Lutomirski <luto@...nel.org>

(I'm about to send, and I see PeterZ beat me to the punch.  You can
still have the ack, though.)