linux-kernel - Re: [PATCH 13/17] remoteproc/omap: add support for system suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0fe03eb-86c9-8c67-684e-b1f6f606b7ed@ti.com>
Date:   Tue, 12 Nov 2019 10:45:18 +0200
From:   Tero Kristo <t-kristo@...com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
CC:     <ohad@...ery.com>, <linux-remoteproc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <s-anna@...com>
Subject: Re: [PATCH 13/17] remoteproc/omap: add support for system
 suspend/resume

On 12/11/2019 08:15, Bjorn Andersson wrote:
> On Mon 28 Oct 05:42 PDT 2019, Tero Kristo wrote:
>> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
> [..]
>> +static int _omap_rproc_suspend(struct rproc *rproc)
> 
> I think it would make sense to inline this and _omap_rproc_resume() in
> their single call sites.

Well, these get re-used in following patch for runtime PM also, so it is 
probably better leave this for compiler to decide?

> 
> [..]
>> +static int _omap_rproc_resume(struct rproc *rproc)
>> +{
> [..]
>> @@ -806,6 +972,14 @@ static int omap_rproc_probe(struct platform_device *pdev)
>>   			oproc->num_timers);
>>   	}
>>   
>> +	init_completion(&oproc->pm_comp);
>> +
>> +	oproc->fck = of_clk_get(np, 0);
> 
> devm_clk_get() ?
> 
> Otherwise I think you're lacking a clk_put() in omap_rproc_remove()

Yeah, let me replace with devm_clk_get.

-Tero

> 
> Regards,
> Bjorn
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki