linux-kernel - Re: [PATCH 15/17] remoteproc/omap: report device exceptions and trigger recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a88ac4e2-ff00-f1d2-2339-72c3315687e4@ti.com>
Date:   Tue, 12 Nov 2019 10:46:15 +0200
From:   Tero Kristo <t-kristo@...com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
CC:     <ohad@...ery.com>, <linux-remoteproc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <s-anna@...com>
Subject: Re: [PATCH 15/17] remoteproc/omap: report device exceptions and
 trigger recovery

On 12/11/2019 08:26, Bjorn Andersson wrote:
> On Mon 28 Oct 05:42 PDT 2019, Tero Kristo wrote:
> 
>> From: Suman Anna <s-anna@...com>
>>
>> The OMAP remote processors send a special mailbox message
>> (RP_MBOX_CRASH) when they crash and detect an internal device
>> exception.
>>
>> Add support to the mailbox handling function upon detection of
>> this special message to report this crash to the remoteproc core.
>> The remoteproc core can trigger a recovery using the prevailing
>> recovery mechanism, already in use for MMU Fault recovery.
>>
>> Signed-off-by: Subramaniam Chanderashekarapuram <subramaniam.ca@...com>
>> Signed-off-by: Suman Anna <s-anna@...com>
> 
> You're missing a Co-developed-by

Yep, let me fix that.

-Tero

> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> 
>> Signed-off-by: Tero Kristo <t-kristo@...com>
>> ---
>>   drivers/remoteproc/omap_remoteproc.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
>> index 8bd415c8fc86..6f797025bb6b 100644
>> --- a/drivers/remoteproc/omap_remoteproc.c
>> +++ b/drivers/remoteproc/omap_remoteproc.c
>> @@ -360,8 +360,12 @@ static void omap_rproc_mbox_callback(struct mbox_client *client, void *data)
>>   
>>   	switch (msg) {
>>   	case RP_MBOX_CRASH:
>> -		/* just log this for now. later, we'll also do recovery */
>> +		/*
>> +		 * remoteproc detected an exception, notify the rproc core.
>> +		 * The remoteproc core will handle the recovery.
>> +		 */
>>   		dev_err(dev, "omap rproc %s crashed\n", name);
>> +		rproc_report_crash(oproc->rproc, RPROC_FATAL_ERROR);
>>   		break;
>>   	case RP_MBOX_ECHO_REPLY:
>>   		dev_info(dev, "received echo reply from %s\n", name);
>> -- 
>> 2.17.1
>>
>> --

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki