linux-kernel - Re: [RESEND PATCH v1 1/2] scsi: ufs: print helpful hint when response size exceed buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df3c0dc2-4ee6-1927-27b6-723d4e721ac5@acm.org>
Date:   Tue, 12 Nov 2019 08:40:38 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     "Bean Huo (beanhuo)" <beanhuo@...ron.com>,
        "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "pedrom.sousa@...opsys.com" <pedrom.sousa@...opsys.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "tomas.winkler@...el.com" <tomas.winkler@...el.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>
Cc:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH v1 1/2] scsi: ufs: print helpful hint when response
 size exceed buffer size

On 11/11/19 4:21 PM, Bean Huo (beanhuo) wrote:
> 
> Bean Huo <beanhuo@...ron.com>
> 
> Reset since ver.kernel.org rejected outlook.com.
> Print out returned response size and buffer size, while the front one
> is bigger than the back one.
> 
> Signed-off-by: Bean Huo <beanhuo@...ron.com>
> ---
>   drivers/scsi/ufs/ufshcd.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 11a87f51c442..fdb4f5b7f4bd 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1935,8 +1935,8 @@ int ufshcd_copy_query_response(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
>   			memcpy(hba->dev_cmd.query.descriptor, descp, resp_len);
>   		} else {
>   			dev_warn(hba->dev,
> -				"%s: Response size is bigger than buffer",
> -				__func__);
> +				 "%s: rsp size %d is bigger than buffer size %d",
> +				 __func__, resp_len, buf_len);
>   			return -EINVAL;
>   		}
>   	}
> @@ -5856,7 +5856,9 @@ static int ufshcd_issue_devman_upiu_cmd(struct ufs_hba *hba,
>   			memcpy(desc_buff, descp, resp_len);
>   			*buff_len = resp_len;
>   		} else {
> -			dev_warn(hba->dev, "rsp size is bigger than buffer");
> +			dev_warn(hba->dev,
> +				 "%s: rsp size %d is bigger than buffer size %d",
> +				 __func__, resp_len, *buff_len);
>   			*buff_len = 0;
>   			err = -EINVAL;
>   		}

Hi Bean,

Please use git format-patch and/or git send-email to publish patches 
such that the standard format is used ("From: " is missing from the 
first line). Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>