linux-kernel - Re: [RESEND PATCH v1 2/2] scsi: ufs: fix potential bug which ends in system hang-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f923772d-2105-e2b2-8503-4e87fd1bc180@acm.org>
Date:   Tue, 12 Nov 2019 08:41:20 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     "Bean Huo (beanhuo)" <beanhuo@...ron.com>,
        "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "pedrom.sousa@...opsys.com" <pedrom.sousa@...opsys.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "tomas.winkler@...el.com" <tomas.winkler@...el.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>
Cc:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH v1 2/2] scsi: ufs: fix potential bug which ends in
 system hang-up

On 11/11/19 4:22 PM, Bean Huo (beanhuo) wrote:
> 
> Bean Huo <beanhuo@...ron.com>
> 
> In function __ufshcd_query_descriptor(), in the event of an error
> happening, we directly goto out_unlock, and forget to invaliate
> hba->dev_cmd.query.descriptor pointer. Thus results in this pointer
> still validity in ufshcd_copy_query_response() for other query requests
> which go through ufshcd_exec_raw_upiu_cmd(). This will cuases __memcpy()
> crash and system hangs up, log shows as below:

Reviewed-by: Bart Van Assche <bvanassche@....org>